Commit eb0851e1 authored by I Hsin Cheng's avatar I Hsin Cheng Committed by Neil Armstrong
Browse files

drm/meson: Use 1000ULL when operating with mode->clock 

Coverity scan reported the usage of "mode->clock * 1000" may lead to
integer overflow. Use "1000ULL" instead of "1000"
when utilizing it to avoid potential integer overflow issue.

Link: https://scan5.scan.coverity.com/#/project-view/10074/10063?selectedIssue=1646759


Signed-off-by: default avatarI Hsin Cheng <richard120310@gmail.com>
Reviewed-by: default avatarMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Fixes: 10175601 ("drm/meson: use unsigned long long / Hz for frequency types")
Link: https://lore.kernel.org/r/20250505184338.678540-1-richard120310@gmail.com


Signed-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
parent 7c6fa179

drivers/gpu/drm/meson/meson_encoder_hdmi.c

+2 −2
Original line number Diff line number Diff line
@@ -75,7 +75,7 @@ static void meson_encoder_hdmi_set_vclk(struct meson_encoder_hdmi *encoder_hdmi, 
	unsigned long long venc_freq;

	unsigned long long hdmi_freq;



	vclk_freq = mode->clock * 1000;

	vclk_freq = mode->clock * 1000ULL;



	/* For 420, pixel clock is half unlike venc clock */

	if (encoder_hdmi->output_bus_fmt == MEDIA_BUS_FMT_UYYVYY8_0_5X24)
@@ -123,7 +123,7 @@ static enum drm_mode_status meson_encoder_hdmi_mode_valid(struct drm_bridge *bri 
	struct meson_encoder_hdmi *encoder_hdmi = bridge_to_meson_encoder_hdmi(bridge);

	struct meson_drm *priv = encoder_hdmi->priv;

	bool is_hdmi2_sink = display_info->hdmi.scdc.supported;

	unsigned long long clock = mode->clock * 1000;

	unsigned long long clock = mode->clock * 1000ULL;

	unsigned long long phy_freq;

	unsigned long long vclk_freq;

	unsigned long long venc_freq;