Commit eb183b2c authored by Will Deacon's avatar Will Deacon
Browse files

Revert "perf/arm_dmc620: Remove duplicate format attribute #defines" 

This reverts commit a5f4ca68.

Pulling in the Arm-specific 'linux/perf/arm_pmu.h' header breaks the
allmodconfig build for x86:

> In file included from drivers/perf/arm_dmc620_pmu.c:26:
> include/linux/perf/arm_pmu.h:15:10: fatal error: asm/cputype.h: No such file or directory
>    15 | #include <asm/cputype.h>
>       |          ^~~~~~~~~~~~~~~

Just put things back like they were so that the driver can continue to
be compile-tested on a variety of architectures.

Link: https://lore.kernel.org/r/20231213100931.12d9d85e@canb.auug.org.au


Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent bd690638

drivers/perf/arm_dmc620_pmu.c

+21 −1
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ 
#include <linux/module.h>

#include <linux/mutex.h>

#include <linux/perf_event.h>

#include <linux/perf/arm_pmu.h>

#include <linux/platform_device.h>

#include <linux/printk.h>

#include <linux/rculist.h>
@@ -190,6 +189,27 @@ static const struct attribute_group dmc620_pmu_events_attr_group = { 
#define ATTR_CFG_FLD_clkdiv2_LO		9

#define ATTR_CFG_FLD_clkdiv2_HI		9



#define __GEN_PMU_FORMAT_ATTR(cfg, lo, hi)			\

	(lo) == (hi) ? #cfg ":" #lo "\n" : #cfg ":" #lo "-" #hi



#define _GEN_PMU_FORMAT_ATTR(cfg, lo, hi)			\

	__GEN_PMU_FORMAT_ATTR(cfg, lo, hi)



#define GEN_PMU_FORMAT_ATTR(name)				\

	PMU_FORMAT_ATTR(name,					\

	_GEN_PMU_FORMAT_ATTR(ATTR_CFG_FLD_##name##_CFG,		\

			     ATTR_CFG_FLD_##name##_LO,		\

			     ATTR_CFG_FLD_##name##_HI))



#define _ATTR_CFG_GET_FLD(attr, cfg, lo, hi)			\

	((((attr)->cfg) >> lo) & GENMASK_ULL(hi - lo, 0))



#define ATTR_CFG_GET_FLD(attr, name)				\

	_ATTR_CFG_GET_FLD(attr,					\

			  ATTR_CFG_FLD_##name##_CFG,		\

			  ATTR_CFG_FLD_##name##_LO,		\

			  ATTR_CFG_FLD_##name##_HI)



GEN_PMU_FORMAT_ATTR(mask);

GEN_PMU_FORMAT_ATTR(match);

GEN_PMU_FORMAT_ATTR(invert);