Commit eb3a04a8 authored by Miklos Szeredi's avatar Miklos Szeredi
Browse files

ovl: don't allow datadir only 



In theory overlayfs could support upper layer directly referring to a data
layer, but there's no current use case for this.

Originally, when data-only layers were introduced, this wasn't allowed,
only introduced by the "datadir+" feature, but without actually handling
this case, resulting in an Oops.

Fix by disallowing datadir without lowerdir.

Reported-by: default avatarGiuseppe Scrivano <gscrivan@redhat.com>
Fixes: 24e16e38 ("ovl: add support for appending lowerdirs one by one")
Cc: <stable@vger.kernel.org> # v6.7
Reviewed-by: default avatarAmir Goldstein <amir73il@gmail.com>
Reviewed-by: default avatarAlexander Larsson <alexl@redhat.com>
Reviewed-by: default avatarChristian Brauner <brauner@kernel.org>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent 0af2f6be

fs/overlayfs/super.c

+5 −0
Original line number Diff line number Diff line
@@ -1138,6 +1138,11 @@ static struct ovl_entry *ovl_get_lowerstack(struct super_block *sb, 
		return ERR_PTR(-EINVAL);

	}



	if (ctx->nr == ctx->nr_data) {

		pr_err("at least one non-data lowerdir is required\n");

		return ERR_PTR(-EINVAL);

	}



	err = -EINVAL;

	for (i = 0; i < ctx->nr; i++) {

		l = &ctx->lower[i];