Commit eb4917f5 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

serial: amba-pl011: prefer dma_mapping_error() over explicit address checking 



Check for returned DMA addresses using specialized dma_mapping_error()
helper which is generally recommended for this purpose by
Documentation/core-api/dma-api.rst:

  "In some circumstances dma_map_single(), ...
will fail to create a mapping. A driver can check for these errors
by testing the returned DMA address with dma_mapping_error()."

Found via static analysis and this is similar to commit fa030813
("ALSA: memalloc: prefer dma_mapping_error() over explicit address checking")

Fixes: 58ac1b37 ("ARM: PL011: Fix DMA support")
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarGregory CLEMENT <gregory.clement@bootlin.com>
Link: https://patch.msgid.link/20251027092053.87937-1-linmq006@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dcb6fa37

drivers/tty/serial/amba-pl011.c

+1 −1
Original line number Diff line number Diff line
@@ -628,7 +628,7 @@ static int pl011_dma_tx_refill(struct uart_amba_port *uap) 
	dmatx->len = count;

	dmatx->dma = dma_map_single(dma_dev->dev, dmatx->buf, count,

				    DMA_TO_DEVICE);

	if (dmatx->dma == DMA_MAPPING_ERROR) {

	if (dma_mapping_error(dma_dev->dev, dmatx->dma)) {

		uap->dmatx.queued = false;

		dev_dbg(uap->port.dev, "unable to map TX DMA\n");

		return -EBUSY;