Unverified Commit eb5c7982 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Mark Brown
Browse files

firmware: cs_dsp: FW_CS_DSP_KUNIT_TEST should not select REGMAP 



Enabling a (modular) test should not silently enable additional kernel
functionality, as that may increase the attack vector of a product.

Fix this by making FW_CS_DSP_KUNIT_TEST (and FW_CS_DSP_KUNIT_TEST_UTILS)
depend on REGMAP instead of selecting it.

After this, one can safely enable CONFIG_KUNIT_ALL_TESTS=m to build
modules for all appropriate tests for ones system, without pulling in
extra unwanted functionality, while still allowing a tester to manually
enable REGMAP_BUILD and this test suite on a system where REGMAP is not
enabled by default.

Fixes: dd0b6b1f ("firmware: cs_dsp: Add KUnit testing of bin file download")
Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Link: https://patch.msgid.link/73c81ac85e21f1c5a75b7628d90cbb0e1b4ed0fa.1737833376.git.geert@linux-m68k.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2e3c688d

drivers/firmware/cirrus/Kconfig

+2 −4
Original line number Diff line number Diff line
@@ -6,15 +6,13 @@ config FW_CS_DSP 


config FW_CS_DSP_KUNIT_TEST_UTILS

	tristate

	depends on KUNIT

	select REGMAP

	depends on KUNIT && REGMAP

	select FW_CS_DSP



config FW_CS_DSP_KUNIT_TEST

	tristate "KUnit tests for Cirrus Logic cs_dsp" if !KUNIT_ALL_TESTS

	depends on KUNIT

	depends on KUNIT && REGMAP

	default KUNIT_ALL_TESTS

	select REGMAP

	select FW_CS_DSP

	select FW_CS_DSP_KUNIT_TEST_UTILS

	help