Commit eb9eb4db authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Linus Walleij
Browse files

driver core: make pinctrl_bind_pins() private 



pinctrl_bind_pins() is only used by driver core (as it should). Move it
out of the public header into base.h.

Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: default avatarDanilo Krummrich <dakr@kernel.org>
Signed-off-by: default avatarLinus Walleij <linusw@kernel.org>
parent 43519f54

drivers/base/base.h

+9 −0
Original line number Diff line number Diff line
@@ -289,3 +289,12 @@ static inline int devtmpfs_delete_node(struct device *dev) { return 0; } 


void software_node_notify(struct device *dev);

void software_node_notify_remove(struct device *dev);



#ifdef CONFIG_PINCTRL

int pinctrl_bind_pins(struct device *dev);

#else

static inline int pinctrl_bind_pins(struct device *dev)

{

	return 0;

}

#endif /* CONFIG_PINCTRL */

drivers/base/pinctrl.c

+2 −0
Original line number Diff line number Diff line
@@ -14,6 +14,8 @@ 
#include <linux/pinctrl/consumer.h>

#include <linux/slab.h>



#include "base.h"



/**

 * pinctrl_bind_pins() - called by the device core before probe

 * @dev: the device that is just about to probe

include/linux/pinctrl/devinfo.h

+0 −6
Original line number Diff line number Diff line
@@ -43,7 +43,6 @@ struct dev_pin_info { 
#endif

};



extern int pinctrl_bind_pins(struct device *dev);

extern int pinctrl_init_done(struct device *dev);



static inline struct pinctrl *dev_pinctrl(struct device *dev)
@@ -58,11 +57,6 @@ static inline struct pinctrl *dev_pinctrl(struct device *dev) 


/* Stubs if we're not using pinctrl */



static inline int pinctrl_bind_pins(struct device *dev)

{

	return 0;

}



static inline int pinctrl_init_done(struct device *dev)

{

	return 0;