Commit ebb8308e authored by Simon Horman's avatar Simon Horman Committed by Jakub Kicinski
Browse files

gve: Avoid unnecessary use of comma operator 



Although it does not seem to have any untoward side-effects,
the use of ';' to separate to assignments seems more appropriate than ','.

Flagged by clang-18 -Wcomma

No functional change intended.
Compile tested only.

Reviewed-by: default avatarShailend Chand <shailend@google.com>
Reviewed-by: default avatarLarysa Zaremba <larysa.zaremba@intel.com>
Signed-off-by: default avatarSimon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240508-gve-comma-v2-1-1ac919225f13@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b9d5f571

drivers/net/ethernet/google/gve/gve_adminq.c

+2 −2
Original line number Diff line number Diff line
@@ -650,9 +650,9 @@ static void gve_adminq_get_create_rx_queue_cmd(struct gve_priv *priv, 
			GVE_RAW_ADDRESSING_QPL_ID : rx->data.qpl->id;



		cmd->create_rx_queue.rx_desc_ring_addr =

			cpu_to_be64(rx->desc.bus),

			cpu_to_be64(rx->desc.bus);

		cmd->create_rx_queue.rx_data_ring_addr =

			cpu_to_be64(rx->data.data_bus),

			cpu_to_be64(rx->data.data_bus);

		cmd->create_rx_queue.index = cpu_to_be32(queue_index);

		cmd->create_rx_queue.queue_page_list_id = cpu_to_be32(qpl_id);

		cmd->create_rx_queue.packet_buffer_size = cpu_to_be16(rx->packet_buffer_size);