Unverified Commit ebeef57b authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

spi: dt-bindings: fsl: Correct GPIO flags in the example 



IRQ_TYPE_xxx flags are not correct in the context of GPIO flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning: IRQ_TYPE_EDGE_RISING = 1 = GPIO_ACTIVE_LOW.

Correct the example DTS to use proper flags for chip select GPIOs,
assuming the author of the code wanted similar logical behavior:

  IRQ_TYPE_EDGE_RISING => GPIO_ACTIVE_HIGH

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260413085947.51047-2-krzysztof.kozlowski@oss.qualcomm.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c4c3fc87

Documentation/devicetree/bindings/spi/fsl,spi.yaml

+3 −3
Original line number Diff line number Diff line
@@ -59,7 +59,7 @@ unevaluatedProperties: false 


examples:

  - |

    #include <dt-bindings/interrupt-controller/irq.h>

    #include <dt-bindings/gpio/gpio.h>



    spi@4c0 {

        compatible = "fsl,spi";
@@ -67,8 +67,8 @@ examples: 
        cell-index = <0>;

        interrupts = <82 0>;

        mode = "cpu";

        cs-gpios = <&gpio 18 IRQ_TYPE_EDGE_RISING          // device reg=<0>

                    &gpio 19 IRQ_TYPE_EDGE_RISING>;        // device reg=<1>

        cs-gpios = <&gpio 18 GPIO_ACTIVE_HIGH>,        // device reg=<0>

                   <&gpio 19 GPIO_ACTIVE_HIGH>;        // device reg=<1>

    };



...