Commit ec177e46 authored by Sean Anderson's avatar Sean Anderson Committed by Vinod Koul
Browse files

dma: Add lockdep asserts to virt-dma 



Add lockdep asserts to all functions with "vc.lock must be held by
caller" in their documentation. This will help catch cases where these
assumptions do not hold.

Signed-off-by: default avatarSean Anderson <sean.anderson@linux.dev>
Reviewed-by: default avatarTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://lore.kernel.org/r/20240308210034.3634938-4-sean.anderson@linux.dev


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 28ccf02c

drivers/dma/virt-dma.h

+10 −0
Original line number Diff line number Diff line
@@ -81,6 +81,8 @@ static inline struct dma_async_tx_descriptor *vchan_tx_prep(struct virt_dma_chan 
 */

static inline bool vchan_issue_pending(struct virt_dma_chan *vc)

{

	lockdep_assert_held(&vc->lock);



	list_splice_tail_init(&vc->desc_submitted, &vc->desc_issued);

	return !list_empty(&vc->desc_issued);

}
@@ -96,6 +98,8 @@ static inline void vchan_cookie_complete(struct virt_dma_desc *vd) 
	struct virt_dma_chan *vc = to_virt_chan(vd->tx.chan);

	dma_cookie_t cookie;



	lockdep_assert_held(&vc->lock);



	cookie = vd->tx.cookie;

	dma_cookie_complete(&vd->tx);

	dev_vdbg(vc->chan.device->dev, "txd %p[%x]: marked complete\n",
@@ -146,6 +150,8 @@ static inline void vchan_terminate_vdesc(struct virt_dma_desc *vd) 
{

	struct virt_dma_chan *vc = to_virt_chan(vd->tx.chan);



	lockdep_assert_held(&vc->lock);



	list_add_tail(&vd->node, &vc->desc_terminated);



	if (vc->cyclic == vd)
@@ -160,6 +166,8 @@ static inline void vchan_terminate_vdesc(struct virt_dma_desc *vd) 
 */

static inline struct virt_dma_desc *vchan_next_desc(struct virt_dma_chan *vc)

{

	lockdep_assert_held(&vc->lock);



	return list_first_entry_or_null(&vc->desc_issued,

					struct virt_dma_desc, node);

}
@@ -177,6 +185,8 @@ static inline struct virt_dma_desc *vchan_next_desc(struct virt_dma_chan *vc) 
static inline void vchan_get_all_descriptors(struct virt_dma_chan *vc,

	struct list_head *head)

{

	lockdep_assert_held(&vc->lock);



	list_splice_tail_init(&vc->desc_allocated, head);

	list_splice_tail_init(&vc->desc_submitted, head);

	list_splice_tail_init(&vc->desc_issued, head);