Commit ec3803b5 authored by Daniel Golle's avatar Daniel Golle Committed by Jakub Kicinski
Browse files

net: phy: mxl-gpy: fix bogus error on USXGMII and integrated PHY 



As the interface mode doesn't need to be updated on PHYs connected with
USXGMII and integrated PHYs, gpy_update_interface() should just return 0
in these cases rather than -EINVAL which has wrongly been introduced by
commit 7a495dde ("net: phy: mxl-gpy: Change gpy_update_interface()
function return type"), as this breaks support for those PHYs.

Fixes: 7a495dde ("net: phy: mxl-gpy: Change gpy_update_interface() function return type")
Signed-off-by: default avatarDaniel Golle <daniel@makrotopia.org>
Reviewed-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/f744f721a1fcc5e2e936428c62ff2c7d94d2a293.1763648168.git.daniel@makrotopia.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a14602fc

drivers/net/phy/mxl-gpy.c

+1 −1
Original line number Diff line number Diff line
@@ -540,7 +540,7 @@ static int gpy_update_interface(struct phy_device *phydev) 
	/* Interface mode is fixed for USXGMII and integrated PHY */

	if (phydev->interface == PHY_INTERFACE_MODE_USXGMII ||

	    phydev->interface == PHY_INTERFACE_MODE_INTERNAL)

		return -EINVAL;

		return 0;



	/* Automatically switch SERDES interface between SGMII and 2500-BaseX

	 * according to speed. Disable ANEG in 2500-BaseX mode.