Commit ec50ec37 authored by Breno Leitao's avatar Breno Leitao Committed by Corey Minyard
Browse files

ipmi: Use dev_warn_ratelimited() for incorrect message warnings 



During BMC firmware upgrades on live systems, the ipmi_msghandler
generates excessive "BMC returned incorrect response" warnings
while the BMC is temporarily offline. This can flood system logs
in large deployments.

Replace dev_warn() with dev_warn_ratelimited() to throttle these
warnings and prevent log spam during BMC maintenance operations.

Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Message-ID: <20250710-ipmi_ratelimit-v1-1-6d417015ebe9@debian.org>
Signed-off-by: default avatarCorey Minyard <corey@minyard.net>
parent f6f97603

drivers/char/ipmi/ipmi_msghandler.c

+4 −4
Original line number Diff line number Diff line
@@ -4607,7 +4607,7 @@ static int handle_one_recv_msg(struct ipmi_smi *intf, 
		 * The NetFN and Command in the response is not even

		 * marginally correct.

		 */

		dev_warn(intf->si_dev,

		dev_warn_ratelimited(intf->si_dev,

				     "BMC returned incorrect response, expected netfn %x cmd %x, got netfn %x cmd %x\n",

				     (msg->data[0] >> 2) | 1, msg->data[1],

				     msg->rsp[0] >> 2, msg->rsp[1]);