Commit ec538867 authored by Sunday Adelodun's avatar Sunday Adelodun Committed by Jakub Kicinski
Browse files

net: unix: remove outdated BSD behavior comment in unix_release_sock() 



Remove the long-standing comment in unix_release_sock() that described a
behavioral difference between Linux and BSD regarding when ECONNRESET is
sent to connected UNIX sockets upon closure.

As confirmed by testing on macOS (similar to BSD behavior), ECONNRESET
is only observed for SOCK_DGRAM sockets, not for SOCK_STREAM. Meanwhile,
Linux already returns ECONNRESET in cases where a socket is closed with
unread data or is not yet accept()ed. This means the previous comment no
longer accurately describes current behavior and is misleading.

Suggested-by: default avatarKuniyuki Iwashima <kuniyu@google.com>
Signed-off-by: default avatarSunday Adelodun <adelodunolaoluwa@yahoo.com>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20251021195906.20389-1-adelodunolaoluwa@yahoo.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 99ad2b68

net/unix/af_unix.c

+0 −11
Original line number Diff line number Diff line
@@ -733,17 +733,6 @@ static void unix_release_sock(struct sock *sk, int embrion) 


	/* ---- Socket is dead now and most probably destroyed ---- */



	/*

	 * Fixme: BSD difference: In BSD all sockets connected to us get

	 *	  ECONNRESET and we die on the spot. In Linux we behave

	 *	  like files and pipes do and wait for the last

	 *	  dereference.

	 *

	 * Can't we simply set sock->err?

	 *

	 *	  What the above comment does talk about? --ANK(980817)

	 */



	if (READ_ONCE(unix_tot_inflight))

		unix_gc();		/* Garbage collect fds */

}