Commit ec7384ec authored by Julia Lawall's avatar Julia Lawall Committed by Sage Weil
Browse files

ceph: remove duplicate variable initialization 

The variable client is initialized twice to the same (side effect-free)
expression.  Drop one initialization.

A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/

)

// <smpl>
@forall@
idexpression *x;
identifier f!=ERR_PTR;
@@

x = f(...)
... when != x
(
x = f(...,<+...x...+>,...)
|
* x = f(...)
)
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarSage Weil <sage@newdream.net>
parent 7740a42f

fs/ceph/addr.c

+1 −1
Original line number Diff line number Diff line
@@ -596,7 +596,7 @@ static int ceph_writepages_start(struct address_space *mapping, 
	struct inode *inode = mapping->host;

	struct backing_dev_info *bdi = mapping->backing_dev_info;

	struct ceph_inode_info *ci = ceph_inode(inode);

	struct ceph_client *client = ceph_inode_to_client(inode);

	struct ceph_client *client;

	pgoff_t index, start, end;

	int range_whole = 0;

	int should_loop = 1;