Commit eca71038 authored by Claudiu Beznea's avatar Claudiu Beznea Committed by Greg Kroah-Hartman
Browse files

driver core: auxiliary bus: Drop dev_pm_domain_detach() call 



Starting with commit f9950807 ("PM: domains: Detach on
device_unbind_cleanup()"), there is no longer a need to call
dev_pm_domain_detach() in the bus remove function. The
device_unbind_cleanup() function now handles this to avoid
invoking devres cleanup handlers while the PM domain is
powered off, which could otherwise lead to failures as
described in the above-mentioned commit.

Drop the explicit dev_pm_domain_detach() call and rely instead
on the flags passed to dev_pm_domain_attach() to power off the
domain.

Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Link: https://lore.kernel.org/r/20250827100541.926350-1-claudiu.beznea.uj@bp.renesas.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 716cec5f

drivers/base/auxiliary.c

+3 −7
Original line number Diff line number Diff line
@@ -217,17 +217,14 @@ static int auxiliary_bus_probe(struct device *dev) 
	struct auxiliary_device *auxdev = to_auxiliary_dev(dev);

	int ret;



	ret = dev_pm_domain_attach(dev, PD_FLAG_ATTACH_POWER_ON);

	ret = dev_pm_domain_attach(dev, PD_FLAG_ATTACH_POWER_ON |

					PD_FLAG_DETACH_POWER_OFF);

	if (ret) {

		dev_warn(dev, "Failed to attach to PM Domain : %d\n", ret);

		return ret;

	}



	ret = auxdrv->probe(auxdev, auxiliary_match_id(auxdrv->id_table, auxdev));

	if (ret)

		dev_pm_domain_detach(dev, true);



	return ret;

	return auxdrv->probe(auxdev, auxiliary_match_id(auxdrv->id_table, auxdev));

}



static void auxiliary_bus_remove(struct device *dev)
@@ -237,7 +234,6 @@ static void auxiliary_bus_remove(struct device *dev) 


	if (auxdrv->remove)

		auxdrv->remove(auxdev);

	dev_pm_domain_detach(dev, true);

}



static void auxiliary_bus_shutdown(struct device *dev)