Commit ecaaa55c authored by Terry Tritton's avatar Terry Tritton Committed by Kees Cook
Browse files

selftests/seccomp: Handle EINVAL on unshare(CLONE_NEWPID) 



unshare(CLONE_NEWPID) can return EINVAL if the kernel does not have the
CONFIG_PID_NS option enabled.

Add a check on these calls to skip the test if we receive EINVAL.

Signed-off-by: default avatarTerry Tritton <terry.tritton@linaro.org>
Link: https://lore.kernel.org/r/20240124141357.1243457-2-terry.tritton@linaro.org


Signed-off-by: default avatarKees Cook <keescook@chromium.org>
parent 41bccc98

tools/testing/selftests/seccomp/seccomp_bpf.c

+8 −1
Original line number Diff line number Diff line
@@ -3709,7 +3709,12 @@ TEST(user_notification_sibling_pid_ns) 
	ASSERT_GE(pid, 0);



	if (pid == 0) {

		ASSERT_EQ(unshare(CLONE_NEWPID), 0);

		ASSERT_EQ(unshare(CLONE_NEWPID), 0) {

			if (errno == EPERM)

				SKIP(return, "CLONE_NEWPID requires CAP_SYS_ADMIN");

			else if (errno == EINVAL)

				SKIP(return, "CLONE_NEWPID is invalid (missing CONFIG_PID_NS?)");

		}



		pid2 = fork();

		ASSERT_GE(pid2, 0);
@@ -3727,6 +3732,8 @@ TEST(user_notification_sibling_pid_ns) 
	ASSERT_EQ(unshare(CLONE_NEWPID), 0) {

		if (errno == EPERM)

			SKIP(return, "CLONE_NEWPID requires CAP_SYS_ADMIN");

		else if (errno == EINVAL)

			SKIP(return, "CLONE_NEWPID is invalid (missing CONFIG_PID_NS?)");

	}

	ASSERT_EQ(errno, 0);