Commit eccdb0fd authored by Lech Perczak's avatar Lech Perczak Committed by Greg Kroah-Hartman
Browse files

serial: sc16is7xx: fix copy-paste errors in EFR_SWFLOWx_BIT constants 



Comments attached to bits 0 and 1 incorrectly referenced bits 2 and 3,
which don't match the datasheet - fix them.
At the same time remove comments for individual constants, as they add
nothing to the definitions themselves.

Signed-off-by: default avatarLech Perczak <lech.perczak@camlingroup.com>
Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/r/2986a485-935d-4ab2-9a16-4a85288aa15a@camlingroup.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0f5e3898

drivers/tty/serial/sc16is7xx.c

+7 −7
Original line number Diff line number Diff line
@@ -267,9 +267,9 @@ 
						  * and writing to IER[7:4],

						  * FCR[5:4], MCR[7:5]

						  */

#define SC16IS7XX_EFR_SWFLOW3_BIT	(1 << 3) /* SWFLOW bit 3 */

#define SC16IS7XX_EFR_SWFLOW2_BIT	(1 << 2) /* SWFLOW bit 2

						  *

#define SC16IS7XX_EFR_SWFLOW3_BIT	(1 << 3)

#define SC16IS7XX_EFR_SWFLOW2_BIT	(1 << 2)

						 /*

						  * SWFLOW bits 3 & 2 table:

						  * 00 -> no transmitter flow

						  *       control
@@ -281,10 +281,10 @@ 
						  *       XON1, XON2, XOFF1 and

						  *       XOFF2

						  */

#define SC16IS7XX_EFR_SWFLOW1_BIT	(1 << 1) /* SWFLOW bit 2 */

#define SC16IS7XX_EFR_SWFLOW0_BIT	(1 << 0) /* SWFLOW bit 3

						  *

						  * SWFLOW bits 3 & 2 table:

#define SC16IS7XX_EFR_SWFLOW1_BIT	(1 << 1)

#define SC16IS7XX_EFR_SWFLOW0_BIT	(1 << 0)

						 /*

						  * SWFLOW bits 1 & 0 table:

						  * 00 -> no received flow

						  *       control

						  * 01 -> receiver compares