Commit ecd9ecc7 authored by Niklas Cassel's avatar Niklas Cassel Committed by Damien Le Moal
Browse files

ata: libata-sata: Use BIT() macro to convert tag to bit field 



The BIT() macro is commonly used in the kernel.
Make use of it when converting a tag, fetched from the Successful NCQ
Commands log or the NCQ Command Error log, to a bit field.
This makes the code easier to read.

Suggested-by: default avatarIgor Pylypiv <ipylypiv@google.com>
Signed-off-by: default avatarNiklas Cassel <cassel@kernel.org>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Reviewed-by: default avatarIgor Pylypiv <ipylypiv@google.com>
Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
parent f5446445

drivers/ata/libata-sata.c

+2 −2
Original line number Diff line number Diff line
@@ -1545,7 +1545,7 @@ int ata_eh_get_ncq_success_sense(struct ata_link *link) 
		 * If the command does not have any sense data, clear ATA_SENSE.

		 * Keep ATA_QCFLAG_EH_SUCCESS_CMD so that command is finished.

		 */

		if (!(sense_valid & (1 << tag))) {

		if (!(sense_valid & BIT(tag))) {

			qc->result_tf.status &= ~ATA_SENSE;

			continue;

		}
@@ -1634,7 +1634,7 @@ void ata_eh_analyze_ncq_error(struct ata_link *link) 
		return;

	}



	if (!(link->sactive & (1 << tag))) {

	if (!(link->sactive & BIT(tag))) {

		ata_link_err(link, "log page 10h reported inactive tag %d\n",

			     tag);

		return;