Commit ece5cc2a authored by Tudor Ambarus's avatar Tudor Ambarus Committed by Greg Kroah-Hartman
Browse files

tty: serial: samsung: don't compare with zero an if (bitwise expression) 



The bitwise AND with the fifo mask is used to check if the fifo is empty
or not, it doesn't care about the length, thus the comparison with zero
is implicit. Rely on the implicit comparison instead.

Reviewed-by: default avatarSam Protsenko <semen.protsenko@linaro.org>
Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@linaro.org>
Link: https://lore.kernel.org/r/20240119104526.1221243-14-tudor.ambarus@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b3296e76

drivers/tty/serial/samsung_tty.c

+1 −1
Original line number Diff line number Diff line
@@ -988,7 +988,7 @@ static unsigned int s3c24xx_serial_tx_empty(struct uart_port *port) 
	u32 ufcon = rd_regl(port, S3C2410_UFCON);



	if (ufcon & S3C2410_UFCON_FIFOMODE) {

		if ((ufstat & info->tx_fifomask) != 0 ||

		if ((ufstat & info->tx_fifomask) ||

		    (ufstat & info->tx_fifofull))

			return 0;

		return TIOCSER_TEMT;