Commit ed1a72fb authored by Dan Carpenter's avatar Dan Carpenter Committed by Shuah Khan
Browse files

kunit: Fix a NULL vs IS_ERR() bug 



The kunit_device_register() function doesn't return NULL, it returns
error pointers.  Change the KUNIT_ASSERT_NOT_NULL() to check for
ERR_OR_NULL().

Fixes: d03c720e ("kunit: Add APIs for managing devices")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarRae Moar <rmoar@google.com>
Reviewed-by: default avatarDavid Gow <davidgow@google.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 6613476e

lib/kunit/kunit-test.c

+1 −1
Original line number Diff line number Diff line
@@ -720,7 +720,7 @@ static void kunit_device_cleanup_test(struct kunit *test) 
	long action_was_run = 0;



	test_device = kunit_device_register(test, "my_device");

	KUNIT_ASSERT_NOT_NULL(test, test_device);

	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, test_device);



	/* Add an action to verify cleanup. */

	devm_add_action(test_device, test_dev_action, &action_was_run);