Commit ed32169b authored by Johan Hovold's avatar Johan Hovold Committed by Jeff Johnson
Browse files

wifi: ath12k: fix dest ring-buffer corruption when ring is full 



Add the missing memory barriers to make sure that destination ring
descriptors are read before updating the tail pointer (and passing
ownership to the device) to avoid memory corruption on weakly ordered
architectures like aarch64 when the ring is full.

Tested-on: WCN7850 hw2.0 WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Fixes: d8899132 ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Cc: stable@vger.kernel.org      # 6.3
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarBaochen Qiang <quic_bqiang@quicinc.com>
Link: https://patch.msgid.link/20250617084402.14475-5-johan+linaro@kernel.org


Signed-off-by: default avatarJeff Johnson <jeff.johnson@oss.qualcomm.com>
parent e834da4c

drivers/net/wireless/ath/ath12k/hal.c

+9 −2
Original line number Diff line number Diff line
@@ -2170,7 +2170,6 @@ void ath12k_hal_srng_access_end(struct ath12k_base *ab, struct hal_srng *srng) 
{

	lockdep_assert_held(&srng->lock);



	/* TODO: See if we need a write memory barrier here */

	if (srng->flags & HAL_SRNG_FLAGS_LMAC_RING) {

		/* For LMAC rings, ring pointer updates are done through FW and

		 * hence written to a shared memory location that is read by FW
@@ -2185,7 +2184,11 @@ void ath12k_hal_srng_access_end(struct ath12k_base *ab, struct hal_srng *srng) 
			WRITE_ONCE(*srng->u.src_ring.hp_addr, srng->u.src_ring.hp);

		} else {

			srng->u.dst_ring.last_hp = *srng->u.dst_ring.hp_addr;

			*srng->u.dst_ring.tp_addr = srng->u.dst_ring.tp;

			/* Make sure descriptor is read before updating the

			 * tail pointer.

			 */

			dma_mb();

			WRITE_ONCE(*srng->u.dst_ring.tp_addr, srng->u.dst_ring.tp);

		}

	} else {

		if (srng->ring_dir == HAL_SRNG_DIR_SRC) {
@@ -2201,6 +2204,10 @@ void ath12k_hal_srng_access_end(struct ath12k_base *ab, struct hal_srng *srng) 
					   srng->u.src_ring.hp);

		} else {

			srng->u.dst_ring.last_hp = *srng->u.dst_ring.hp_addr;

			/* Make sure descriptor is read before updating the

			 * tail pointer.

			 */

			mb();

			ath12k_hif_write32(ab,

					   (unsigned long)srng->u.dst_ring.tp_addr -

					   (unsigned long)ab->mem,