Commit ed33fbb5 authored by Markus Elfring's avatar Markus Elfring Committed by Chanwoo Choi
Browse files

PM / devfreq: event: Call of_node_put() only once in devfreq_event_get_edev_by_phandle() 

An of_node_put(node) call was immediately used after a null pointer check
for the local variable “edev” at the end of this function implementation.
Thus call such a function only once instead directly before the check.

This issue was transformed by using the Coccinelle software.

Link: https://lore.kernel.org/lkml/0f103384-376c-41f0-a35c-8ad98327d6cb@web.de/


Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent 40384c84

drivers/devfreq/devfreq-event.c

+2 −6
Original line number Diff line number Diff line
@@ -244,13 +244,9 @@ struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(struct device *dev, 
	edev = NULL;

out:

	mutex_unlock(&devfreq_event_list_lock);



	if (!edev) {

	of_node_put(node);

	if (!edev)

		return ERR_PTR(-ENODEV);

	}



	of_node_put(node);



	return edev;

}