Commit ed344511 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: cleanup {g,s]etsockopt sqe reading 



Add a local variable for the sqe pointer to avoid repetition.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/8dbac0f9acda2d3842534eeb7ce10d9276b021ae.1743357108.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 296e1696

io_uring/uring_cmd.c

+10 −8
Original line number Diff line number Diff line
@@ -307,17 +307,18 @@ static inline int io_uring_cmd_getsockopt(struct socket *sock, 
					  struct io_uring_cmd *cmd,

					  unsigned int issue_flags)

{

	const struct io_uring_sqe *sqe = cmd->sqe;

	bool compat = !!(issue_flags & IO_URING_F_COMPAT);

	int optlen, optname, level, err;

	void __user *optval;



	level = READ_ONCE(cmd->sqe->level);

	level = READ_ONCE(sqe->level);

	if (level != SOL_SOCKET)

		return -EOPNOTSUPP;



	optval = u64_to_user_ptr(READ_ONCE(cmd->sqe->optval));

	optname = READ_ONCE(cmd->sqe->optname);

	optlen = READ_ONCE(cmd->sqe->optlen);

	optval = u64_to_user_ptr(READ_ONCE(sqe->optval));

	optname = READ_ONCE(sqe->optname);

	optlen = READ_ONCE(sqe->optlen);



	err = do_sock_getsockopt(sock, compat, level, optname,

				 USER_SOCKPTR(optval),
@@ -333,15 +334,16 @@ static inline int io_uring_cmd_setsockopt(struct socket *sock, 
					  struct io_uring_cmd *cmd,

					  unsigned int issue_flags)

{

	const struct io_uring_sqe *sqe = cmd->sqe;

	bool compat = !!(issue_flags & IO_URING_F_COMPAT);

	int optname, optlen, level;

	void __user *optval;

	sockptr_t optval_s;



	optval = u64_to_user_ptr(READ_ONCE(cmd->sqe->optval));

	optname = READ_ONCE(cmd->sqe->optname);

	optlen = READ_ONCE(cmd->sqe->optlen);

	level = READ_ONCE(cmd->sqe->level);

	optval = u64_to_user_ptr(READ_ONCE(sqe->optval));

	optname = READ_ONCE(sqe->optname);

	optlen = READ_ONCE(sqe->optlen);

	level = READ_ONCE(sqe->level);

	optval_s = USER_SOCKPTR(optval);



	return do_sock_setsockopt(sock, compat, level, optname, optval_s,