Commit ed43c40e authored by Luca Coelho's avatar Luca Coelho Committed by Suraj Kandpal
Browse files

drm/i915: move uapi.event outside spinlock in intel_crtc_vblank_work 



In intel_crtc_vblank_work(), we access uapi.event before grabbing the
event_lock spinlock, but modify it inside the spinlock block.  This
causes some static analyzers to get confused and issue a warning.

The uapi.event value is not protected by the event_lock, so we can
safely move it out of the protected block to prevent false positives.

Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarSuraj Kandpal <suraj.kandpal@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240528112901.476068-3-luciano.coelho@intel.com
parent b2c2f2df

drivers/gpu/drm/i915/display/intel_crtc.c

+1 −1
Original line number Diff line number Diff line
@@ -411,8 +411,8 @@ static void intel_crtc_vblank_work(struct kthread_work *base) 
	if (crtc_state->uapi.event) {

		spin_lock_irq(&crtc->base.dev->event_lock);

		drm_crtc_send_vblank_event(&crtc->base, crtc_state->uapi.event);

		crtc_state->uapi.event = NULL;

		spin_unlock_irq(&crtc->base.dev->event_lock);

		crtc_state->uapi.event = NULL;

	}



	trace_intel_crtc_vblank_work_end(crtc);