Commit ed7326a2 authored by Stefan Binding's avatar Stefan Binding Committed by Takashi Iwai
Browse files

ALSA: hda: cs35l41: Do not allow uninitialised variables to be freed 



Initialise the variables to NULL so that they cannot be uninitialised
when devm_kfree is called.

Found by static analysis.

Fixes: 8c4c216d ("ALSA: hda: cs35l41: Add config table to support many laptops without _DSD")

Signed-off-by: default avatarStefan Binding <sbinding@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20231219162232.790358-2-sbinding@opensource.cirrus.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 092a1362

sound/pci/hda/cs35l41_hda_property.c

+4 −4
Original line number Diff line number Diff line
@@ -77,10 +77,10 @@ static const struct cs35l41_config cs35l41_config_table[] = { 
static int cs35l41_add_gpios(struct cs35l41_hda *cs35l41, struct device *physdev, int reset_gpio,

			     int spkid_gpio, int cs_gpio_index, int num_amps)

{

	struct acpi_gpio_mapping *gpio_mapping;

	struct acpi_gpio_params *reset_gpio_params;

	struct acpi_gpio_params *spkid_gpio_params;

	struct acpi_gpio_params *cs_gpio_params;

	struct acpi_gpio_mapping *gpio_mapping = NULL;

	struct acpi_gpio_params *reset_gpio_params = NULL;

	struct acpi_gpio_params *spkid_gpio_params = NULL;

	struct acpi_gpio_params *cs_gpio_params = NULL;

	unsigned int num_entries = 0;

	unsigned int reset_index, spkid_index, csgpio_index;

	int i;