Commit edb82534 authored by Charles Keepax's avatar Charles Keepax Committed by Mark Brown
Browse files

ASoC: SDCA: Move most of the messages from info to debug 



The SDCA code is very spammy on boot as it prints a lot of parsing
details using info prints. Now primary development is complete move
these to debug prints to reduce the spam.

Tested-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarMaciej Strozek <mstrozek@opensource.cirrus.com>
Reviewed-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Tested-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20251120153023.2105663-7-ckeepax@opensource.cirrus.com


Reviewed-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 336beae2

sound/soc/sdca/sdca_functions.c

+24 −26
Original line number Diff line number Diff line
@@ -6,8 +6,6 @@ 
 * https://www.mipi.org/mipi-sdca-v1-0-download

 */



#define dev_fmt(fmt) "%s: " fmt, __func__



#include <linux/acpi.h>

#include <linux/byteorder/generic.h>

#include <linux/cleanup.h>
@@ -1013,7 +1011,7 @@ static int find_sdca_entity_control(struct device *dev, struct sdca_entity *enti 
	control->type = find_sdca_control_datatype(entity, control);

	control->nbits = find_sdca_control_bits(entity, control);



	dev_info(dev, "%s: %s: control %#x mode %#x layers %#x cn %#llx int %d %s\n",

	dev_dbg(dev, "%s: %s: control %#x mode %#x layers %#x cn %#llx int %d %s\n",

		entity->label, control->label, control->sel,

		control->mode, control->layers, control->cn_list,

		control->interrupt_position, control->deferrable ? "deferrable" : "");
@@ -1137,7 +1135,7 @@ static int find_sdca_entity_iot(struct device *dev, 
	if (!ret)

		terminal->num_transducer = tmp;



	dev_info(dev, "%s: terminal type %#x ref %#x conn %#x count %d\n",

	dev_dbg(dev, "%s: terminal type %#x ref %#x conn %#x count %d\n",

		entity->label, terminal->type, terminal->reference,

		terminal->connector, terminal->num_transducer);
@@ -1165,7 +1163,7 @@ static int find_sdca_entity_cs(struct device *dev, 
	if (!ret)

		clock->max_delay = tmp;



	dev_info(dev, "%s: clock type %#x delay %d\n", entity->label,

	dev_dbg(dev, "%s: clock type %#x delay %d\n", entity->label,

		clock->type, clock->max_delay);



	return 0;
@@ -1217,7 +1215,7 @@ static int find_sdca_entity_pde(struct device *dev, 
		delays[i].to_ps = delay_list[j++];

		delays[i].us = delay_list[j++];



		dev_info(dev, "%s: from %#x to %#x delay %dus\n", entity->label,

		dev_dbg(dev, "%s: from %#x to %#x delay %dus\n", entity->label,

			delays[i].from_ps, delays[i].to_ps, delays[i].us);

	}
@@ -1447,7 +1445,7 @@ static int find_sdca_entity(struct device *dev, struct sdw_slave *sdw, 


	entity->type = tmp;



	dev_info(dev, "%s: entity %#x type %#x\n",

	dev_dbg(dev, "%s: entity %#x type %#x\n",

		entity->label, entity->id, entity->type);



	switch (entity->type) {
@@ -1623,7 +1621,7 @@ static int find_sdca_entity_connection_iot(struct device *dev, 


	terminal->clock = clock_entity;



	dev_info(dev, "%s -> %s\n", clock_entity->label, entity->label);

	dev_dbg(dev, "%s -> %s\n", clock_entity->label, entity->label);



	fwnode_handle_put(clock_node);

	return 0;
@@ -1673,7 +1671,7 @@ static int find_sdca_entity_connection_pde(struct device *dev, 
			return -EINVAL;

		}



		dev_info(dev, "%s -> %s\n", managed[i]->label, entity->label);

		dev_dbg(dev, "%s -> %s\n", managed[i]->label, entity->label);

	}



	power->num_managed = num_managed;
@@ -1808,7 +1806,7 @@ static int find_sdca_entity_connection(struct device *dev, 


		pins[i] = connected_entity;



		dev_info(dev, "%s -> %s\n", connected_entity->label, entity->label);

		dev_dbg(dev, "%s -> %s\n", connected_entity->label, entity->label);



		i++;

		fwnode_handle_put(connected_node);
@@ -1893,7 +1891,7 @@ static int find_sdca_cluster_channel(struct device *dev, 


	channel->relationship = tmp;



	dev_info(dev, "cluster %#x: channel id %#x purpose %#x relationship %#x\n",

	dev_dbg(dev, "cluster %#x: channel id %#x purpose %#x relationship %#x\n",

		cluster->id, channel->id, channel->purpose, channel->relationship);



	return 0;
@@ -2065,7 +2063,7 @@ static int find_sdca_filesets(struct device *dev, struct sdw_slave *sdw, 
			return -EINVAL;

		}



		dev_info(dev, "fileset: %#x\n", filesets_list[i]);

		dev_dbg(dev, "fileset: %#x\n", filesets_list[i]);



		files = devm_kcalloc(dev, num_entries / mult_fileset,

				     sizeof(struct sdca_fdl_file), GFP_KERNEL);
@@ -2086,7 +2084,7 @@ static int find_sdca_filesets(struct device *dev, struct sdw_slave *sdw, 
			file->file_id = fileset_entries[j++];

			file->fdl_offset = fileset_entries[j++];



			dev_info(dev, "file: %#x, vendor: %#x, offset: %#x\n",

			dev_dbg(dev, "file: %#x, vendor: %#x, offset: %#x\n",

				file->file_id, file->vendor_id, file->fdl_offset);

		}
@@ -2130,7 +2128,7 @@ int sdca_parse_function(struct device *dev, struct sdw_slave *sdw, 
	if (!ret)

		function->reset_max_delay = tmp;



	dev_info(dev, "%pfwP: name %s busy delay %dus reset delay %dus\n",

	dev_dbg(dev, "%pfwP: name %s busy delay %dus reset delay %dus\n",

		function->desc->node, function->desc->name,

		function->busy_max_delay, function->reset_max_delay);