Commit ede481f6 authored by Kees Cook's avatar Kees Cook Committed by Helge Deller
Browse files

fbdev: arkfb: Cast ics5342_init() allocation type 



In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "struct dac_info *" but the returned type will be
"struct ics5342_info *", which has a larger allocation size. This is
by design, as struct ics5342_info contains struct dac_info as its first
member.
(patch slightly modified by Helge Deller)

Signed-off-by: default avatarKees Cook <kees@kernel.org>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 34fe05cd

drivers/video/fbdev/arkfb.c

+3 −2
Original line number Diff line number Diff line
@@ -431,9 +431,10 @@ static struct dac_ops ics5342_ops = { 


static struct dac_info * ics5342_init(dac_read_regs_t drr, dac_write_regs_t dwr, void *data)

{

	struct dac_info *info = kzalloc(sizeof(struct ics5342_info), GFP_KERNEL);

	struct ics5342_info *ics_info = kzalloc(sizeof(struct ics5342_info), GFP_KERNEL);

	struct dac_info *info = &ics_info->dac;



	if (! info)

	if (!ics_info)

		return NULL;



	info->dacops = &ics5342_ops;