Commit ee064390 authored by André Draszik's avatar André Draszik Committed by Vinod Koul
Browse files

phy: exynos5-usbdrd: convert to dev_err_probe 



dev_err_probe() exists to simplify code.

Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarPeter Griffin <peter.griffin@linaro.org>
Signed-off-by: default avatarAndré Draszik <andre.draszik@linaro.org>
Tested-by: default avatarWill McVicker <willmcvicker@google.com>
Link: https://lore.kernel.org/r/20241206-gs101-phy-lanes-orientation-phy-v4-3-f5961268b149@linaro.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent c3852881

drivers/phy/samsung/phy-exynos5-usbdrd.c

+9 −12
Original line number Diff line number Diff line
@@ -1725,10 +1725,9 @@ static int exynos5_usbdrd_phy_probe(struct platform_device *pdev) 


	reg_pmu = syscon_regmap_lookup_by_phandle(dev->of_node,

						   "samsung,pmu-syscon");

	if (IS_ERR(reg_pmu)) {

		dev_err(dev, "Failed to lookup PMU regmap\n");

		return PTR_ERR(reg_pmu);

	}

	if (IS_ERR(reg_pmu))

		return dev_err_probe(dev, PTR_ERR(reg_pmu),

				     "Failed to lookup PMU regmap\n");



	/*

	 * Exynos5420 SoC has multiple channels for USB 3.0 PHY, with
@@ -1759,10 +1758,9 @@ static int exynos5_usbdrd_phy_probe(struct platform_device *pdev) 
	for (i = 0; i < EXYNOS5_DRDPHYS_NUM; i++) {

		struct phy *phy = devm_phy_create(dev, NULL, drv_data->phy_ops);



		if (IS_ERR(phy)) {

			dev_err(dev, "Failed to create usbdrd_phy phy\n");

			return PTR_ERR(phy);

		}

		if (IS_ERR(phy))

			return dev_err_probe(dev, PTR_ERR(phy),

					     "Failed to create usbdrd_phy phy\n");



		phy_drd->phys[i].phy = phy;

		phy_drd->phys[i].index = i;
@@ -1786,10 +1784,9 @@ static int exynos5_usbdrd_phy_probe(struct platform_device *pdev) 


	phy_provider = devm_of_phy_provider_register(dev,

						     exynos5_usbdrd_phy_xlate);

	if (IS_ERR(phy_provider)) {

		dev_err(phy_drd->dev, "Failed to register phy provider\n");

		return PTR_ERR(phy_provider);

	}

	if (IS_ERR(phy_provider))

		return dev_err_probe(phy_drd->dev, PTR_ERR(phy_provider),

				     "Failed to register phy provider\n");



	return 0;

}