Commit ee0b48fa authored by Josh Poimboeuf's avatar Josh Poimboeuf Committed by Peter Zijlstra
Browse files

objtool: Set minimum xxhash version to 0.8 

XXH3 is only supported starting with xxhash 0.8.  Enforce that.

Fixes: 0d83da43 ("objtool/klp: Add --checksum option to generate per-function checksums")
Closes: https://lore.kernel.org/SN6PR02MB41579B83CD295C9FEE40EED6D4FCA@SN6PR02MB4157.namprd02.prod.outlook.com


Reported-by: default avatarMichael Kelley <mhklinux@outlook.com>
Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarMichael Kelley <mhklinux@outlook.com>
Tested-by: default avatarMichael Kelley <mhklinux@outlook.com>
Link: https://patch.msgid.link/7227c94692a3a51840278744c7af31b4797c6b96.1762990139.git.jpoimboe@kernel.org
parent 9c7dc1dd

tools/objtool/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@ ifeq ($(SRCARCH),loongarch) 
endif



ifeq ($(ARCH_HAS_KLP),y)

	HAVE_XXHASH = $(shell echo "int main() {}" | \

	HAVE_XXHASH = $(shell printf "$(pound)include <xxhash.h>\nXXH3_state_t *state;int main() {}" | \

		      $(HOSTCC) -xc - -o /dev/null -lxxhash 2> /dev/null && echo y || echo n)

	ifeq ($(HAVE_XXHASH),y)

		BUILD_KLP	 := y

tools/objtool/builtin-check.c

+1 −1
Original line number Diff line number Diff line
@@ -164,7 +164,7 @@ static bool opts_valid(void) 


#ifndef BUILD_KLP

	if (opts.checksum) {

		ERROR("--checksum not supported; install xxhash-devel/libxxhash-dev and recompile");

		ERROR("--checksum not supported; install xxhash-devel/libxxhash-dev (version >= 0.8) and recompile");

		return false;

	}

#endif