Commit ee367109 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ufs: core: Remove the ufshcd_hba_exit() call from ufshcd_async_scan() 



Calling ufshcd_hba_exit() from a function that is called asynchronously
from ufshcd_init() is wrong because this triggers multiple race
conditions. Instead of calling ufshcd_hba_exit(), log an error message.

Reported-by: default avatarDaniel Mentz <danielmentz@google.com>
Fixes: 1d337ec2 ("ufs: improve init sequence")
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20231218225229.2542156-3-bvanassche@acm.org


Reviewed-by: default avatarCan Guo <quic_cang@quicinc.com>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent daf77954

drivers/ufs/core/ufshcd.c

+2 −5
Original line number Diff line number Diff line
@@ -8982,12 +8982,9 @@ static void ufshcd_async_scan(void *data, async_cookie_t cookie) 


out:

	pm_runtime_put_sync(hba->dev);

	/*

	 * If we failed to initialize the device or the device is not

	 * present, turn off the power/clocks etc.

	 */



	if (ret)

		ufshcd_hba_exit(hba);

		dev_err(hba->dev, "%s failed: %d\n", __func__, ret);

}



static enum scsi_timeout_action ufshcd_eh_timed_out(struct scsi_cmnd *scmd)