Commit ee3878b8 authored by Stefan Wahren's avatar Stefan Wahren Committed by Thomas Gleixner
Browse files

irqchip/bcm2836: Enable SKIP_SET_WAKE and MASK_ON_SUSPEND 



The BCM2836 interrupt controller doesn't provide any facility to configure
the wakeup sources. That's the reason why the driver lacks the
irq_set_wake() callback for the interrupt chip.

Enable the flags IRQCHIP_SKIP_SET_WAKE and IRQCHIP_MASK_ON_SUSPEND so the
interrupt suspend logic can handle the chip correctly equivalently to the
corresponding bcm2835 change (9a58480e ("irqchip/bcm2835: Enable
SKIP_SET_WAKE and MASK_ON_SUSPEND").

Signed-off-by: default avatarStefan Wahren <wahrenst@gmx.net>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Acked-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/all/20241202115437.33552-1-wahrenst@gmx.net
parent f58326c7

drivers/irqchip/irq-bcm2836.c

+3 −0
Original line number Diff line number Diff line
@@ -58,6 +58,7 @@ static struct irq_chip bcm2836_arm_irqchip_timer = { 
	.name		= "bcm2836-timer",

	.irq_mask	= bcm2836_arm_irqchip_mask_timer_irq,

	.irq_unmask	= bcm2836_arm_irqchip_unmask_timer_irq,

	.flags		= IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_SKIP_SET_WAKE,

};



static void bcm2836_arm_irqchip_mask_pmu_irq(struct irq_data *d)
@@ -74,6 +75,7 @@ static struct irq_chip bcm2836_arm_irqchip_pmu = { 
	.name		= "bcm2836-pmu",

	.irq_mask	= bcm2836_arm_irqchip_mask_pmu_irq,

	.irq_unmask	= bcm2836_arm_irqchip_unmask_pmu_irq,

	.flags		= IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_SKIP_SET_WAKE,

};



static void bcm2836_arm_irqchip_mask_gpu_irq(struct irq_data *d)
@@ -88,6 +90,7 @@ static struct irq_chip bcm2836_arm_irqchip_gpu = { 
	.name		= "bcm2836-gpu",

	.irq_mask	= bcm2836_arm_irqchip_mask_gpu_irq,

	.irq_unmask	= bcm2836_arm_irqchip_unmask_gpu_irq,

	.flags		= IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_SKIP_SET_WAKE,

};



static void bcm2836_arm_irqchip_dummy_op(struct irq_data *d)