Commit ee64510f authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

x86/ioapic: Move replace_pin_at_irq_node() to the call site 



It's only used by check_timer().

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Tested-by: default avatarQiuxu Zhuo <qiuxu.zhuo@intel.com>
Tested-by: default avatarBreno Leitao <leitao@debian.org>
Link: https://lore.kernel.org/all/20240802155440.906636514@linutronix.de
parent 48855a2c

arch/x86/kernel/apic/io_apic.c

+18 −22
Original line number Diff line number Diff line
@@ -370,28 +370,6 @@ static void __remove_pin_from_irq(struct mp_chip_data *data, int apic, int pin) 
		}

}



/*

 * Reroute an IRQ to a different pin.

 */

static void __init replace_pin_at_irq_node(struct mp_chip_data *data, int node,

					   int oldapic, int oldpin,

					   int newapic, int newpin)

{

	struct irq_pin_list *entry;



	for_each_irq_pin(entry, data->irq_2_pin) {

		if (entry->apic == oldapic && entry->pin == oldpin) {

			entry->apic = newapic;

			entry->pin = newpin;

			/* every one is different, right? */

			return;

		}

	}



	/* old apic/pin didn't exist, so just add new ones */

	add_pin_to_irq_node(data, node, newapic, newpin);

}



static void io_apic_modify_irq(struct mp_chip_data *data, bool masked,

			       void (*final)(struct irq_pin_list *entry))

{
@@ -2067,6 +2045,24 @@ static int __init mp_alloc_timer_irq(int ioapic, int pin) 
	return irq;

}



static void __init replace_pin_at_irq_node(struct mp_chip_data *data, int node,

					   int oldapic, int oldpin,

					   int newapic, int newpin)

{

	struct irq_pin_list *entry;



	for_each_irq_pin(entry, data->irq_2_pin) {

		if (entry->apic == oldapic && entry->pin == oldpin) {

			entry->apic = newapic;

			entry->pin = newpin;

			return;

		}

	}



	/* Old apic/pin didn't exist, so just add a new one */

	add_pin_to_irq_node(data, node, newapic, newpin);

}



/*

 * This code may look a bit paranoid, but it's supposed to cooperate with

 * a wide range of boards and BIOS bugs.  Fortunately only the timer IRQ