Commit ee66bc29 authored by Vinicius Costa Gomes's avatar Vinicius Costa Gomes Committed by Vinod Koul
Browse files

dmaengine: idxd: Fix leaking event log memory 



During the device remove process, the device is reset, causing the
configuration registers to go back to their default state, which is
zero. As the driver is checking if the event log support was enabled
before deallocating, it will fail if a reset happened before.

Do not check if the support was enabled, the check for 'idxd->evl'
being valid (only allocated if the HW capability is available) is
enough.

Fixes: 244da66c ("dmaengine: idxd: setup event log configuration")
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Signed-off-by: default avatarVinicius Costa Gomes <vinicius.gomes@intel.com>
Link: https://patch.msgid.link/20260121-idxd-fix-flr-on-kernel-queues-v3-v3-10-7ed70658a9d1@intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent c311f5e9

drivers/dma/idxd/device.c

+0 −4
Original line number Diff line number Diff line
@@ -834,10 +834,6 @@ static void idxd_device_evl_free(struct idxd_device *idxd) 
	if (!evl)

		return;



	gencfg.bits = ioread32(idxd->reg_base + IDXD_GENCFG_OFFSET);

	if (!gencfg.evl_en)

		return;



	mutex_lock(&evl->lock);

	gencfg.evl_en = 0;

	iowrite32(gencfg.bits, idxd->reg_base + IDXD_GENCFG_OFFSET);