Commit ee7e551d authored by Stafford Horne's avatar Stafford Horne
Browse files

openrisc: traps: Remove calls to show_registers before die 



The die function calls show_registers unconditionally.  Remove calls to
show_registers before calling die to avoid printing all registers and
stack status two times during a crash.

This was found when testing kernel trap and floating point exception
handling.

Signed-off-by: default avatarStafford Horne <shorne@gmail.com>
parent c8fdf82e

arch/openrisc/kernel/traps.c

+0 −3
Original line number Diff line number Diff line
@@ -212,7 +212,6 @@ asmlinkage void do_unaligned_access(struct pt_regs *regs, unsigned long address) 
		force_sig_fault(SIGBUS, BUS_ADRALN, (void __user *)address);

	} else {

		pr_emerg("KERNEL: Unaligned Access 0x%.8lx\n", address);

		show_registers(regs);

		die("Die:", regs, address);

	}
@@ -225,7 +224,6 @@ asmlinkage void do_bus_fault(struct pt_regs *regs, unsigned long address) 
		force_sig_fault(SIGBUS, BUS_ADRERR, (void __user *)address);

	} else {		/* Kernel mode */

		pr_emerg("KERNEL: Bus error (SIGBUS) 0x%.8lx\n", address);

		show_registers(regs);

		die("Die:", regs, address);

	}

}
@@ -421,7 +419,6 @@ asmlinkage void do_illegal_instruction(struct pt_regs *regs, 
	} else {		/* Kernel mode */

		pr_emerg("KERNEL: Illegal instruction (SIGILL) 0x%.8lx\n",

			 address);

		show_registers(regs);

		die("Die:", regs, address);

	}

}