Commit ee8721be authored by Tvrtko Ursulin's avatar Tvrtko Ursulin Committed by Tvrtko Ursulin
Browse files

drm/ttm: Make ttm_bo_init_validate safe against ttm_operation_ctx re-ordering 



Struct ttm_operation_ctx initializer in ttm_bo_init_validate assumes the
order of the structure fields when it is configuring the interruptible
flag.

Fix it by using named initialization.

Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@igalia.com>
Acked-by: default avatarThadeu Lima de Souza Cascardo <cascardo@igalia.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarTvrtko Ursulin <tursulin@ursulin.net>
Link: https://lore.kernel.org/r/20250919131530.91247-2-tvrtko.ursulin@igalia.com
parent ac5b392a

drivers/gpu/drm/ttm/ttm_bo.c

+1 −1
Original line number Diff line number Diff line
@@ -1027,7 +1027,7 @@ int ttm_bo_init_validate(struct ttm_device *bdev, struct ttm_buffer_object *bo, 
			 struct sg_table *sg, struct dma_resv *resv,

			 void (*destroy) (struct ttm_buffer_object *))

{

	struct ttm_operation_ctx ctx = { interruptible, false };

	struct ttm_operation_ctx ctx = { .interruptible = interruptible };

	int ret;



	ret = ttm_bo_init_reserved(bdev, bo, type, placement, alignment, &ctx,