Commit eebe6446 authored by Jan H. Schönherr's avatar Jan H. Schönherr Committed by Peter Zijlstra
Browse files

perf/core: Speed up kexec shutdown by avoiding unnecessary cross CPU calls 



There are typically a lot of PMUs registered, but in many cases only few
of them have an event registered (like the "cpu" PMU in the presence of
the watchdog). As the mutex is already held, it's safe to just check for
existing events before doing the cross CPU call.

This change saves tens of milliseconds from kexec time (perceived as
steal time during a hypervisor host update), with <2ms remaining for
this step in the shutdown. There might be additional potential for
parallelization or we could just disable performance monitoring during
the actual shutdown and be less graceful about it.

Signed-off-by: default avatarJan H. Schönherr <jschoenh@amazon.de>
Signed-off-by: default avatarDavid Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
parent a491c02c

kernel/events/core.c

+2 −1
Original line number Diff line number Diff line
@@ -15066,6 +15066,7 @@ static void perf_event_exit_cpu_context(int cpu) 
	ctx = &cpuctx->ctx;



	mutex_lock(&ctx->mutex);

	if (ctx->nr_events)

		smp_call_function_single(cpu, __perf_event_exit_context, ctx, 1);

	cpuctx->online = 0;

	mutex_unlock(&ctx->mutex);