Commit eebfcb98 authored by Dan Carpenter's avatar Dan Carpenter Committed by Bartosz Golaszewski
Browse files

gpio: aggregator: fix "_sysfs" prefix check in gpio_aggregator_make_group() 



This code is intended to reject strings that start with "_sysfs" but the
strcmp() limit is wrong so checks the whole string instead of the prefix.

Fixes: 83c8e3df ("gpio: aggregator: expose aggregator created via legacy sysfs to configfs")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Acked-by: default avatarKoichiro Den <koichiro.den@canonical.com>
Link: https://lore.kernel.org/r/30210ed77b40b4b6629de659cb56b9ec7832c447.1744452787.git.dan.carpenter@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent 6d7f0c11

drivers/gpio/gpio-aggregator.c

+1 −1
Original line number Diff line number Diff line
@@ -1016,7 +1016,7 @@ gpio_aggregator_make_group(struct config_group *group, const char *name) 
	 * for devices create via legacy sysfs interface.

	 */

	if (strncmp(name, AGGREGATOR_LEGACY_PREFIX,

		    sizeof(AGGREGATOR_LEGACY_PREFIX)) == 0)

		    sizeof(AGGREGATOR_LEGACY_PREFIX) - 1) == 0)

		return ERR_PTR(-EINVAL);



	/* arg space is unneeded */