Commit eee5215b authored by John Harrison's avatar John Harrison
Browse files

drm/i915/guc: Fix flag query helper function to not modify state 



A flag query helper was actually writing to the flags word rather than
just reading. Fix that. Also update the function's comment as it was
out of date.

NB: No need for a 'Fixes' tag. The test was only ever used inside a
BUG_ON during context registration. Rather than asserting that the
condition was true, it was making the condition true. So, in theory,
there was no consequence because we should never have hit a BUG_ON
anyway. Which means the write should always have been a no-op.

Signed-off-by: default avatarJohn Harrison <John.C.Harrison@Intel.com>
Reviewed-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220217212942.629922-1-John.C.Harrison@Intel.com
parent fb87550d

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c

+2 −5
Original line number Diff line number Diff line
@@ -174,11 +174,8 @@ static inline void init_sched_state(struct intel_context *ce) 
__maybe_unused

static bool sched_state_is_init(struct intel_context *ce)

{

	/*

	 * XXX: Kernel contexts can have SCHED_STATE_NO_LOCK_REGISTERED after

	 * suspend.

	 */

	return !(ce->guc_state.sched_state &=

	/* Kernel contexts can have SCHED_STATE_REGISTERED after suspend. */

	return !(ce->guc_state.sched_state &

		 ~(SCHED_STATE_BLOCKED_MASK | SCHED_STATE_REGISTERED));

}