Commit eef2c021 authored by Frieder Schrempf's avatar Frieder Schrempf Committed by Shawn Guo
Browse files

arm64: dts: imx8mm-kontron: Use the VSELECT signal to switch SD card IO voltage 



It turns out that it is not necessary to declare the VSELECT signal as
GPIO and let the PMIC driver set it to a fixed high level. This switches
the voltage between 3.3V and 1.8V by setting the PMIC register for LDO5
accordingly.

Instead we can do it like other boards already do and simply mux the
VSELECT signal of the USDHC interface to the pin. This makes sure that
the correct voltage is selected by setting the PMIC's SD_VSEL input
to high or low accordingly.

Reported-by: default avatarHeiko Thiery <heiko.thiery@gmail.com>
Signed-off-by: default avatarFrieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: default avatarHeiko Thiery <heiko.thiery@gmail.com>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent 587c1fed

arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts

+3 −0
Original line number Diff line number Diff line
@@ -321,6 +321,7 @@ MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d0 
			MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2		0x1d0

			MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3		0x1d0

			MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12		0x019

			MX8MM_IOMUXC_GPIO1_IO04_USDHC2_VSELECT		0x1d0

		>;

	};
@@ -333,6 +334,7 @@ MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d4 
			MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2		0x1d4

			MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3		0x1d4

			MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12		0x019

			MX8MM_IOMUXC_GPIO1_IO04_USDHC2_VSELECT		0x1d0

		>;

	};
@@ -345,6 +347,7 @@ MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d6 
			MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2		0x1d6

			MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3		0x1d6

			MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12		0x019

			MX8MM_IOMUXC_GPIO1_IO04_USDHC2_VSELECT		0x1d0

		>;

	};

};

arch/arm64/boot/dts/freescale/imx8mm-kontron-sl.dtsi

+0 −2
Original line number Diff line number Diff line
@@ -86,7 +86,6 @@ pca9450: pmic@25 { 
		pinctrl-0 = <&pinctrl_pmic>;

		interrupt-parent = <&gpio1>;

		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;

		sd-vsel-gpios = <&gpio1 4 GPIO_ACTIVE_HIGH>;



		regulators {

			reg_vdd_soc: BUCK1 {
@@ -229,7 +228,6 @@ MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3 
	pinctrl_pmic: pmicgrp {

		fsl,pins = <

			MX8MM_IOMUXC_GPIO1_IO00_GPIO1_IO0		0x141

			MX8MM_IOMUXC_GPIO1_IO04_GPIO1_IO4		0x141

		>;

	};