Commit eef5bccf authored by Shenghao Ding's avatar Shenghao Ding Committed by Takashi Iwai
Browse files

ALSA: hda/tas2781: Fix the ld issue reported by kernel test robot 



After commit 9fa6a693 ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c
and leverage SND_SOC_TAS2781_FMWLIB")created a separated lib for i2c,
However, tasdevice_remove() used for not only for I2C but for SPI being
still in that lib caused ld issue.
All errors (new ones prefixed by >>):
>> ld.lld: error: undefined symbol: tasdevice_remove
   >>> referenced by tas2781_hda.c:33 (sound/pci/hda/tas2781_hda.c:33)
   >>>               vmlinux.o:(tas2781_hda_remove)
To fix this issue, the implementation of tasdevice_remove was moved from
tas2781-comlib-i2c.c to tas2781-comlib.c.

Fixes: 9fa6a693 ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c and leverage SND_SOC_TAS2781_FMWLIB")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/202505111855.FP2fScKA-lkp@intel.com/__;!!G3vK!U-wdsvrOG1iezggZ55RYi8ikBxMaJD


Signed-off-by: default avatarShenghao Ding <shenghao-ding@ti.com>
Link: https://patch.msgid.link/20250513085947.1121-1-shenghao-ding@ti.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 6f174dae

sound/soc/codecs/tas2781-comlib-i2c.c

+0 −6
Original line number Diff line number Diff line
@@ -364,12 +364,6 @@ int tascodec_init(struct tasdevice_priv *tas_priv, void *codec, 
}

EXPORT_SYMBOL_GPL(tascodec_init);



void tasdevice_remove(struct tasdevice_priv *tas_priv)

{

	mutex_destroy(&tas_priv->codec_lock);

}

EXPORT_SYMBOL_GPL(tasdevice_remove);



MODULE_DESCRIPTION("TAS2781 common library for I2C");

MODULE_AUTHOR("Shenghao Ding, TI, <shenghao-ding@ti.com>");

MODULE_LICENSE("GPL");

sound/soc/codecs/tas2781-comlib.c

+6 −0
Original line number Diff line number Diff line
@@ -225,6 +225,12 @@ void tasdevice_dsp_remove(void *context) 
}

EXPORT_SYMBOL_GPL(tasdevice_dsp_remove);



void tasdevice_remove(struct tasdevice_priv *tas_priv)

{

	mutex_destroy(&tas_priv->codec_lock);

}

EXPORT_SYMBOL_GPL(tasdevice_remove);



MODULE_DESCRIPTION("TAS2781 common library");

MODULE_AUTHOR("Shenghao Ding, TI, <shenghao-ding@ti.com>");

MODULE_LICENSE("GPL");