Commit ef15ddee authored by Aleksandr Mishin's avatar Aleksandr Mishin Committed by David S. Miller
Browse files

octeontx2-af: Add array index check 



In rvu_map_cgx_lmac_pf() the 'iter', which is used as an array index, can reach
value (up to 14) that exceed the size (MAX_LMAC_COUNT = 8) of the array.
Fix this bug by adding 'iter' value check.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 91c6945e ("octeontx2-af: cn10k: Add RPM MAC support")
Signed-off-by: default avatarAleksandr Mishin <amishin@t-argos.ru>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c53fe72c

drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c

+2 −0
Original line number Diff line number Diff line
@@ -160,6 +160,8 @@ static int rvu_map_cgx_lmac_pf(struct rvu *rvu) 
			continue;

		lmac_bmap = cgx_get_lmac_bmap(rvu_cgx_pdata(cgx, rvu));

		for_each_set_bit(iter, &lmac_bmap, rvu->hw->lmac_per_cgx) {

			if (iter >= MAX_LMAC_COUNT)

				continue;

			lmac = cgx_get_lmacid(rvu_cgx_pdata(cgx, rvu),

					      iter);

			rvu->pf2cgxlmac_map[pf] = cgxlmac_id_to_bmap(cgx, lmac);