Commit ef202378 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Hans Verkuil
Browse files

media: i2c: imx219: Move variables to inner scope 



The exposure_max, exposure_def and hblank variables are only used in an
inner scope in the imx219_set_pad_format() function. Move them to that
scope to keep them closer to their usage and improve readability.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarDave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent bf313f99

drivers/media/i2c/imx219.c

+4 −1
Original line number Diff line number Diff line
@@ -815,7 +815,6 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd, 
{

	struct imx219 *imx219 = to_imx219(sd);

	const struct imx219_mode *mode;

	int exposure_max, exposure_def, hblank;

	struct v4l2_mbus_framefmt *format;

	struct v4l2_rect *crop;

	unsigned int bin_h, bin_v;
@@ -844,6 +843,10 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd, 
	crop->top = (IMX219_NATIVE_HEIGHT - crop->height) / 2;



	if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE) {

		int exposure_max;

		int exposure_def;

		int hblank;



		/* Update limits and set FPS to default */

		__v4l2_ctrl_modify_range(imx219->vblank, IMX219_VBLANK_MIN,

					 IMX219_VTS_MAX - mode->height, 1,