Commit ef2086a9 authored by Andy Shevchenko's avatar Andy Shevchenko
Browse files

auxdisplay: ht16k33: Add default to switch-cases 



Currently the compiler (GCC) is able to figure out that there is no
other choices possible than those that are already listed in the
switch-cases. However, if we want to move some code to the callback,
compiler will start complaining that no default is defined. Make
sure we have all switch-cases equiped with default.

Reported-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Tested-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 4ce026d5

drivers/auxdisplay/ht16k33.c

+9 −5
Original line number Diff line number Diff line
@@ -677,11 +677,6 @@ static int ht16k33_seg_probe(struct device *dev, struct ht16k33_priv *priv, 
		return err;



	switch (priv->type) {

	case DISP_MATRIX:

		/* not handled here */

		err = -EINVAL;

		break;



	case DISP_QUAD_7SEG:

		INIT_DELAYED_WORK(&priv->work, ht16k33_seg7_update);

		seg->map.seg7 = initial_map_seg7;
@@ -695,6 +690,9 @@ static int ht16k33_seg_probe(struct device *dev, struct ht16k33_priv *priv, 
		seg->map_size = sizeof(seg->map.seg14);

		err = device_create_file(dev, &dev_attr_map_seg14);

		break;



	default:

		return -EINVAL;

	}

	if (err)

		return err;
@@ -772,6 +770,9 @@ static int ht16k33_probe(struct i2c_client *client) 
		/* Segment Display */

		err = ht16k33_seg_probe(dev, priv, dft_brightness);

		break;



	default:

		return -EINVAL;

	}

	return err;

}
@@ -796,6 +797,9 @@ static void ht16k33_remove(struct i2c_client *client) 
		device_remove_file(&client->dev, &dev_attr_map_seg7);

		device_remove_file(&client->dev, &dev_attr_map_seg14);

		break;



	default:

		break;

	}

}