Commit ef48f0f1 authored by Vivek BalachandharTN's avatar Vivek BalachandharTN Committed by Greg Kroah-Hartman
Browse files

misc: bh1770glc: use pm_runtime_resume_and_get() in power_state_store 



pm_runtime_get_sync() may increment the runtime PM usage count even if the
resume fails, which requires an explicit pm_runtime_put_noidle() to balance
it. This driver ignored the return value, risking a usage-count leak on
resume failure.

Replace it with pm_runtime_resume_and_get(), which returns 0 on success and
a negative errno on failure, and only increments the usage count on success.
This simplifies the error path and avoids possible leaks. Also check for
errors explicitly with `if (ret < 0)`.

Signed-off-by: default avatarVivek BalachandharTN <vivek.balachandhar@gmail.com>
Link: https://patch.msgid.link/20251030120022.239951-1-vivek.balachandhar@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 05d36a59

drivers/misc/bh1770glc.c

+3 −1
Original line number Diff line number Diff line
@@ -640,7 +640,9 @@ static ssize_t bh1770_power_state_store(struct device *dev, 


	mutex_lock(&chip->mutex);

	if (value) {

		pm_runtime_get_sync(dev);

		ret = pm_runtime_resume_and_get(dev);

		if (ret < 0)

			goto leave;



		ret = bh1770_lux_rate(chip, chip->lux_rate_index);

		if (ret < 0) {