Commit ef749c8d authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: seq: Avoid client data changes during proc reads 

The proc read of each client should protect against the concurrent
data changes to keep the data consistent; although they are supposed
to be safe and won't crash things, it doesn't guarantee the
consistency between the read values.  Take client->ioctl_mutex for
protecting against the concurrent changes.

Link: https://patch.msgid.link/20250307084246.29271-2-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e3cd33ab

sound/core/seq/seq_clientmgr.c

+2 −0
Original line number Diff line number Diff line
@@ -2706,6 +2706,7 @@ void snd_seq_info_clients_read(struct snd_info_entry *entry, 
			continue;

		}



		mutex_lock(&client->ioctl_mutex);

		snd_iprintf(buffer, "Client %3d : \"%s\" [%s %s]\n",

			    c, client->name,

			    client->type == USER_CLIENT ? "User" : "Kernel",
@@ -2723,6 +2724,7 @@ void snd_seq_info_clients_read(struct snd_info_entry *entry, 
			snd_iprintf(buffer, "  Input pool :\n");

			snd_seq_info_pool(buffer, client->data.user.fifo->pool, "    ");

		}

		mutex_unlock(&client->ioctl_mutex);

		snd_seq_client_unlock(client);

	}

}