Commit ef84aee1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Liu Ying
Browse files

drm/bridge: ite-it6263: Prevent error pointer dereference in probe() 



If devm_i2c_new_dummy_device() fails then we were supposed to return an
error code, but instead the function continues and will crash on the next
line.  Add the missing return statement.

Fixes: 04972362 ("drm/bridge: Add ITE IT6263 LVDS to HDMI converter")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: default avatarLiu Ying <victor.liu@nxp.com>
Signed-off-by: default avatarLiu Ying <victor.liu@nxp.com>
Link: https://patchwork.freedesktop.org/patch/msgid/804a758b-f2e7-4116-b72d-29bc8905beed@stanley.mountain
parent e4b5ccd3

drivers/gpu/drm/bridge/ite-it6263.c

+2 −2
Original line number Diff line number Diff line
@@ -845,7 +845,7 @@ static int it6263_probe(struct i2c_client *client) 
	it->lvds_i2c = devm_i2c_new_dummy_device(dev, client->adapter,

						 LVDS_INPUT_CTRL_I2C_ADDR);

	if (IS_ERR(it->lvds_i2c))

		dev_err_probe(it->dev, PTR_ERR(it->lvds_i2c),

		return dev_err_probe(it->dev, PTR_ERR(it->lvds_i2c),

				     "failed to allocate I2C device for LVDS\n");



	it->lvds_regmap = devm_regmap_init_i2c(it->lvds_i2c,