Commit ef877a15 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: it87: use new line value setter callbacks 



struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Reviewed-by: default avatarPeng Fan <peng.fan@nxp.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250423-gpiochip-set-rv-gpio-part2-v1-5-b22245cde81a@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 40150dda

drivers/gpio/gpio-it87.c

+7 −4
Original line number Diff line number Diff line
@@ -213,8 +213,7 @@ static int it87_gpio_direction_in(struct gpio_chip *chip, unsigned gpio_num) 
	return rc;

}



static void it87_gpio_set(struct gpio_chip *chip,

			  unsigned gpio_num, int val)

static int it87_gpio_set(struct gpio_chip *chip, unsigned int gpio_num, int val)

{

	u8 mask, curr_vals;

	u16 reg;
@@ -228,6 +227,8 @@ static void it87_gpio_set(struct gpio_chip *chip, 
		outb(curr_vals | mask, reg);

	else

		outb(curr_vals & ~mask, reg);



	return 0;

}



static int it87_gpio_direction_out(struct gpio_chip *chip,
@@ -249,7 +250,9 @@ static int it87_gpio_direction_out(struct gpio_chip *chip, 
	/* set the output enable bit */

	superio_set_mask(mask, group + it87_gpio->output_base);



	it87_gpio_set(chip, gpio_num, val);

	rc = it87_gpio_set(chip, gpio_num, val);

	if (rc)

		goto exit;



	superio_exit();
@@ -264,7 +267,7 @@ static const struct gpio_chip it87_template_chip = { 
	.request		= it87_gpio_request,

	.get			= it87_gpio_get,

	.direction_input	= it87_gpio_direction_in,

	.set			= it87_gpio_set,

	.set_rv			= it87_gpio_set,

	.direction_output	= it87_gpio_direction_out,

	.base			= -1

};