Unverified Commit efa5d065 authored by Christian Brauner's avatar Christian Brauner
Browse files

fs: remove dead check 

Above we call super_lock_excl() which waits until the superblock is
SB_BORN and since SB_BORN is never unset once set this check can never
fire. Plus, we also hold an active reference at this point already so
this superblock can't even be shutdown.

Link: https://lore.kernel.org/r/20231104-vfs-multi-device-freeze-v2-1-5b5b69626eac@kernel.org


Tested-by: default avatarChandan Babu R <chandanbabu@kernel.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 5a8e94c0

fs/super.c

+0 −5
Original line number Diff line number Diff line
@@ -1996,11 +1996,6 @@ int freeze_super(struct super_block *sb, enum freeze_holder who) 
		goto retry;

	}



	if (!(sb->s_flags & SB_BORN)) {

		super_unlock_excl(sb);

		return 0;	/* sic - it's "nothing to do" */

	}



	if (sb_rdonly(sb)) {

		/* Nothing to do really... */

		sb->s_writers.freeze_holders |= who;