Commit efa97aed authored by Liu Ying's avatar Liu Ying Committed by Shawn Guo
Browse files

arm64: dts: imx8mm-evk: Fix hdmi@3d node



The hdmi@3d node's compatible string is "adi,adv7535" instead of
"adi,adv7533" or "adi,adv751*".

Fix the hdmi@3d node by means of:
* Use default register addresses for "cec", "edid" and "packet", because
  there is no need to use a non-default address map.
* Add missing interrupt related properties.
* Drop "adi,input-*" properties which are only valid for adv751*.
* Add VDDEXT_3V3 fixed regulator
* Add "*-supply" properties, since most are required.
* Fix label names - s/adv7533/adv7535/.

Fixes: a27335b3 ("arm64: dts: imx8mm-evk: Add HDMI support")
Signed-off-by: default avatarLiu Ying <victor.liu@nxp.com>
Tested-by: default avatarFabio Estevam <festevam@gmail.com>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent 9d1e8275
Loading
Loading
Loading
Loading
+20 −12
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ hdmi-connector {

		port {
			hdmi_connector_in: endpoint {
				remote-endpoint = <&adv7533_out>;
				remote-endpoint = <&adv7535_out>;
			};
		};
	};
@@ -72,6 +72,13 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
		enable-active-high;
	};

	reg_vddext_3v3: regulator-vddext-3v3 {
		compatible = "regulator-fixed";
		regulator-name = "VDDEXT_3V3";
		regulator-min-microvolt = <3300000>;
		regulator-max-microvolt = <3300000>;
	};

	backlight: backlight {
		compatible = "pwm-backlight";
		pwms = <&pwm1 0 5000000 0>;
@@ -317,15 +324,16 @@ &i2c2 {

	hdmi@3d {
		compatible = "adi,adv7535";
		reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>;
		reg-names = "main", "cec", "edid", "packet";
		reg = <0x3d>;
		interrupt-parent = <&gpio1>;
		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
		adi,dsi-lanes = <4>;

		adi,input-depth = <8>;
		adi,input-colorspace = "rgb";
		adi,input-clock = "1x";
		adi,input-style = <1>;
		adi,input-justification = "evenly";
		avdd-supply = <&buck5_reg>;
		dvdd-supply = <&buck5_reg>;
		pvdd-supply = <&buck5_reg>;
		a2vdd-supply = <&buck5_reg>;
		v3p3-supply = <&reg_vddext_3v3>;
		v1p2-supply = <&buck5_reg>;

		ports {
			#address-cells = <1>;
@@ -334,7 +342,7 @@ ports {
			port@0 {
				reg = <0>;

				adv7533_in: endpoint {
				adv7535_in: endpoint {
					remote-endpoint = <&dsi_out>;
				};
			};
@@ -342,7 +350,7 @@ adv7533_in: endpoint {
			port@1 {
				reg = <1>;

				adv7533_out: endpoint {
				adv7535_out: endpoint {
					remote-endpoint = <&hdmi_connector_in>;
				};
			};
@@ -448,7 +456,7 @@ port@1 {
			reg = <1>;

			dsi_out: endpoint {
				remote-endpoint = <&adv7533_in>;
				remote-endpoint = <&adv7535_in>;
				data-lanes = <1 2 3 4>;
			};
		};