Commit efab13e7 authored by Damon Ding's avatar Damon Ding Committed by Dmitry Baryshkov
Browse files

drm/bridge: analogix_dp: Add irq flag IRQF_NO_AUTOEN instead of calling disable_irq() 



The IRQF_NO_AUTOEN can be used for the drivers that don't want
interrupts to be enabled automatically via devm_request_threaded_irq().
Using this flag can provide be more robust compared to the way of
calling disable_irq() after devm_request_threaded_irq() without the
IRQF_NO_AUTOEN flag.

Suggested-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Signed-off-by: default avatarDamon Ding <damon.ding@rock-chips.com>
Link: https://lore.kernel.org/r/20250310104114.2608063-2-damon.ding@rock-chips.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
parent 74757ad1

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

+2 −3
Original line number Diff line number Diff line
@@ -1625,10 +1625,10 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) 
		 * that we can get the current state of the GPIO.

		 */

		dp->irq = gpiod_to_irq(dp->hpd_gpiod);

		irq_flags = IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING;

		irq_flags = IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_NO_AUTOEN;

	} else {

		dp->irq = platform_get_irq(pdev, 0);

		irq_flags = 0;

		irq_flags = IRQF_NO_AUTOEN;

	}



	if (dp->irq == -ENXIO) {
@@ -1645,7 +1645,6 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) 
		dev_err(&pdev->dev, "failed to request irq\n");

		goto err_disable_clk;

	}

	disable_irq(dp->irq);



	return dp;