Commit efb878fb authored by Breno Leitao's avatar Breno Leitao Committed by Paolo Abeni
Browse files

netconsole: Make boolean comparison consistent 

Convert the current state assignment to use explicit boolean conversion,
making the code more robust and easier to read. This change adds a
double-negation operator to ensure consistent boolean conversion as
suggested by Paolo[1].

This approach aligns with the existing pattern used in
sysdata_cpu_nr_enabled_show().

Link: https://lore.kernel.org/all/7309e760-63b0-4b58-ad33-2fb8db361141@redhat.com/

 [1]
Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 8a683295

drivers/net/netconsole.c

+1 −1
Original line number Diff line number Diff line
@@ -850,7 +850,7 @@ static ssize_t sysdata_cpu_nr_enabled_store(struct config_item *item, 
		return ret;



	mutex_lock(&dynamic_netconsole_mutex);

	curr = nt->sysdata_fields & SYSDATA_CPU_NR;

	curr = !!(nt->sysdata_fields & SYSDATA_CPU_NR);

	if (cpu_nr_enabled == curr)

		/* no change requested */

		goto unlock_ok;